Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide tooltips on mobile #3115

Closed
jbibla opened this issue Nov 11, 2019 · 1 comment · Fixed by #3158
Closed

hide tooltips on mobile #3115

jbibla opened this issue Nov 11, 2019 · 1 comment · Fixed by #3158
Assignees
Labels
mobile mobile related issues

Comments

@jbibla
Copy link
Collaborator

jbibla commented Nov 11, 2019

Is your feature request related to a problem? Please describe.

  • the tooltips don't display nicely on mobile. would be best to not use them in the native apps.

Describe the solution you'd like

  • disable them / don't allow them to render based on MOBILE_APP flag

Describe alternatives you've considered

  • perhaps there is some way they won't even be loaded (not just hidden)

Additional context

@jbibla jbibla added the mobile mobile related issues label Nov 11, 2019
@mariopino
Copy link
Contributor

By now implemented using the easy way.

Most optimal solution could be to not import vue-directive-tooltip (and then don't use it with Vue.use) based on MOBILE_APP environment variable value.

Buut I think it is difficult to implement that way since tooltips are inline in the html of components using v-tooltip directive.

That would require to move all the tooltips from the components (content and other attributes like placement ... etc) to custom data directives (like data-tooltip, data-tooltip-placement... etc) and then implement a custom tooltip library to use that data attributes to render the tooltips.

Given that then we can conditionally import our tooltip library based on the value of MOBILE_APP environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile mobile related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants