Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intercom is not working in mobile #3326

Closed
jbibla opened this issue Dec 17, 2019 · 13 comments · Fixed by #3419
Closed

intercom is not working in mobile #3326

jbibla opened this issue Dec 17, 2019 · 13 comments · Fixed by #3419
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@jbibla
Copy link
Collaborator

jbibla commented Dec 17, 2019

intercom has a whitelist and the URL gets obscured in the native apps so they cannot be whitelisted. i have contacted support and they recommended the intercom / ionic docs.

there is a way to install intercom for mobile apps with ionic that should be researched.

@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Jan 6, 2020
@mariopino mariopino self-assigned this Jan 10, 2020
@mariopino
Copy link
Contributor

@faboweb
Copy link
Collaborator

faboweb commented Jan 10, 2020

How do you want to solve this? Maybe good to discuss a plan.

@mariopino
Copy link
Contributor

Sure @faboweb! My plan is to integrate cordova-plugin-intercom cordova plugin into the ionic app.

That way we should be able to add a custom launcher when needed using intercom.displayMessenger(); call.

Another related link, an example cordova app using this:

https://github.com/intercom/intercom-cordova/tree/master/Example

@faboweb
Copy link
Collaborator

faboweb commented Jan 13, 2020

sounds good. let me know when we need to add the environment variables to the build pipeline. I would propose not doing push things for a first version. what do you think?

@mariopino
Copy link
Contributor

sounds good. let me know when we need to add the environment variables to the build pipeline. I would propose not doing push things for a first version. what do you think?

Agree, I'll send you a message before push to discuss the best way to do it

@mariopino
Copy link
Contributor

The cordova plugin was giving me an error ERROR: Could not get unknown property 'cdvCompileSdkVersion' for project ':app' of type org.gradle.api.Project. and don't want to waste more time on it so I decided to try this capacitor plugin:

https://github.com/stewwan/capacitor-intercom

I have it working in Android, currently attached to portfolio page.

Some thoughts about it:

  • What should be the best intercom userId generation possibility, something like lunie-android-1234?
  • IOS integration is pending (seems to be straighforward)
  • Build environments vars to set api key is pending.
  • Best way to only load in mobile.
  • Best place to initialize intercom (initializeApp.js?)
  • I think we should use the same css selector to load intercom either in mobile or desktop.

@faboweb
Copy link
Collaborator

faboweb commented Jan 13, 2020

What should be the best intercom userId generation possibility, something like lunie-android-1234?

sounds good

Best way to only load in mobile.

check here: https://github.com/luniehq/lunie/pull/3209/files#diff-1c90ff38a08209f9ebd4d05d1e43358eR53

Best place to initialize intercom (initializeApp.js?)

sounds good. maybe check for config.isMobile

I think we should use the same css selector to load intercom either in mobile or desktop.

can it be just the same button?

@mariopino
Copy link
Contributor

can it be just the same button?
Yep, this is what I mean.

@mariopino
Copy link
Contributor

check here: https://github.com/luniehq/lunie/pull/3209/files#diff-1c90ff38a08209f9ebd4d05d1e43358eR53

Perfect, Intercom needs push notifications just like in that pr using PushNotifications.register().

@faboweb
Copy link
Collaborator

faboweb commented Jan 14, 2020

let's leave the push notification out for now?

@mariopino
Copy link
Contributor

let's leave the push notification out for now?

I think not, push notifications are needed by Intercom to receive the responses from the Lunie Team.

We can enable it in this pr or wait until your pr gets merged. What do you think it's best?

@faboweb
Copy link
Collaborator

faboweb commented Jan 14, 2020

are you certain they don't receive the messages anyway when the app is open?

@mariopino
Copy link
Contributor

Not needed, you are right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants