fix app header mobile and networks menu arrows #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the fixed view |
|
we need to leave this as is for now. there is no other place where the network link is exposed. |
|
Got it. Should I then make a separate branch for just the app header? |
|
@Bitcoinera just hide the arrow on line 81 instead of the whole link ;) |
added 2 commits
November 14, 2019 20:12
|
Done! |
faboweb
reviewed
Nov 15, 2019
Bitcoinera
force-pushed
the
ana/fix-app-header-mobile-and-app-menu-arrows
branch
from
ed4ec18
to
0dbdb9c
Compare
jbibla
approved these changes
Nov 18, 2019
This was referenced Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3162
Description:
Some fixes for the mobile menu display affecting the AppMenu.vue file.
Fixed the app header not showing when opening the app menu in mobile.
Also fixed the inconsistency in the app menu with Networks showing when turning into mobile.
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: