Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metric field names should be consistent #1261

Closed
danbryan opened this issue Aug 17, 2023 · 0 comments
Closed

metric field names should be consistent #1261

danbryan opened this issue Aug 17, 2023 · 0 comments

Comments

@danbryan
Copy link
Contributor

danbryan commented Aug 17, 2023 •
edited
Loading

This inconsistency makes it hard when querying or aggregating metrics, one would have to account for both fields.
Here's the list:

  1. path_name:

    • cosmos_relayer_client_expiration_seconds
    • cosmos_relayer_client_trusting_period_seconds

  2. path:

    • cosmos_relayer_observed_packets
    • cosmos_relayer_relayed_packets
    • cosmos_relayer_tx_errors_total

I propose we change

  • cosmos_relayer_observed_packets
  • cosmos_relayer_relayed_packets
  • cosmos_relayer_tx_errors_total

to path_name
@danbryan danbryan changed the title metric field names should be the consistent metric field names should be consistent Aug 17, 2023
@danbryan danbryan mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbryan @vimystic