Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to account for upstream changes in ibc-go 02-client refactor #737

Closed
2 tasks
Tracked by #776
jtieri opened this issue May 3, 2022 · 2 comments · Fixed by #1068
Closed
2 tasks
Tracked by #776

Refactor to account for upstream changes in ibc-go 02-client refactor #737

jtieri opened this issue May 3, 2022 · 2 comments · Fixed by #1068
Assignees
@jtieri
Labels
C: Relayer COMPONENT: Relayer R: Major RELEASE: PR contains breaking changes that have to wait till a major release is made to be merged T: Refactor TYPE: Refactor

Comments

@jtieri
Copy link
Member

jtieri commented May 3, 2022 •
edited
Loading

We will need to account for some upstream changes in ibc-go following their completion of the refactor to the 02-client codebase. Creating this issue to keep track of changes that will need to be made in the relayer.

Loose item checklist

  • ibcexported.Header will be replaced by ibcexported.ClientMessage throughout the entire codebase
  • clienttypes.PackHeader() will be removed and replaced with clienttypes.PackClientMessage() see

References:
cosmos/ibc-go#1202 (comment)
cosmos/ibc-go#1107
@jtieri jtieri added R: Major RELEASE: PR contains breaking changes that have to wait till a major release is made to be merged T: Refactor TYPE: Refactor C: Relayer COMPONENT: Relayer labels May 3, 2022
@jtieri jtieri mentioned this issue Jun 6, 2022
Closed
10 tasks
@jtieri
Copy link
Member Author

jtieri commented Jun 10, 2022

Alpha release for the 02-client refactor has been cut https://github.com/cosmos/ibc-go/releases/tag/02-client-refactor-alpha1

This should allow us to begin the process of refactoring to account for the new changes. We could probably start to introduce some unit tests around introduction of the beefy light client

@jtieri jtieri mentioned this issue Jun 14, 2022
Closed
@boojamya boojamya removed this from the v2.1.0-rc1 milestone Aug 2, 2022
@jtieri
Copy link
Member Author

jtieri commented Aug 23, 2022

Updating with new info regarding the 02-client refactor.

Updates to ICA have been prioritized over this refactor which has pushed the expected date for this to November.

@agouin agouin mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtieri jtieri

Labels
C: Relayer COMPONENT: Relayer R: Major RELEASE: PR contains breaking changes that have to wait till a major release is made to be merged T: Refactor TYPE: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tm v0.37.0-rc2, sdk 0.47.0-rc1, and ibc-go v7 cosmos/relayer
2 participants
@jtieri @boojamya