--override doesn't seem to be wired up correctly when creating clients

[boojamya]

rly tx clients <path> is supposed to create a new client on both chains. HOWEVER if you have if you already have a client-id in your config associated with that path, the command will not create a new client.

For example if you config looks like:

paths:
    demopath:
        src:
            chain-id: ibc-0
            client-id: 07-tendermint-0
        dst:
            chain-id: ibc-1
            client-id: 07-tendermint-0
        src-channel-filter:
            rule: ""
            channel-list: []

And you run
rly tx clients demopath
A new client is not created.

AFAIK the --override flag is supposed to override you config and create a new client.
This does not work.

The only way to create a new client is to remove the client-id from your config and re-run command (--override flag is not necessary):

paths:
    demo:
        src:
            chain-id: ibc-0
        dst:
            chain-id: ibc-1
        src-channel-filter:
            rule: ""
            channel-list: []

This is posing issues for client related tests in ibctest

[colin-axner]

From what I remember, the override flag was added to stop automatic reuse of existing clients (ie if you wanted to create a client with X config and that client already existed reuse, but sometimes this caused problems (client already expired) so we added an override flag)

I think it makes sense to repurpose or redesign the UX here as makes sense, I'm not sure how many folks use the override flag

ref #445 #487

[jtieri]

--override should be working as intended now, with the only issue being that the call to findMatchingClient seems to fail in many cases due to broken pagination on the server side.

#1006 has a more detailed write up around this issue and it looks like #1009 may have solved some of the issues but likely not all of them.

I'm going to close out this issue in favor of the one mentioned above.