-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plumbing for Volume Labels #50
Comments
The go-plugin-helpers might not support it after all though? |
If the label stuff does not work, we could work around it for our usecase by making the label the volume driver sets configurable and just deploy the volume driver multiple times. Then we set the volume driver permissions accordingly. Label's would be much simpler and straightforward though. Ah, I forgot, the driver supports prefixing anyways. |
closing this. we will be going down the route of prefixing. |
ok, good to know! Sorry I didn't get around to answering earlier 🙈 |
https://docs.docker.com/reference/api/engine/version/v1.45/#tag/Volume/operation/VolumeCreate The API lists it however. This is weird. I think prefixing is a viable workaround for now, but I think we should get the label support into the driver anyways. It can help for other topics as well to have volumes listed in Hetzner cloud. |
We are building infrastructure for multitenancy around Docker Swarm using labels on objects - see https://github.com/neuroforgede/swarmgate
I would love for this volume plugin to set and get labels from the Hetzner API. This way I can properly use our multi-tenancy concept with the driver.
What do you think @costela ? Should be possible as far as I can tell.
https://github.com/moby/moby/blob/93fffa299c2cb23055bb54c380a02d53c9a7d525/daemon/cluster/executor/container/container.go#L444
https://github.com/moby/moby/blob/93fffa299c2cb23055bb54c380a02d53c9a7d525/volume/drivers/proxy.go#L26
The text was updated successfully, but these errors were encountered: