Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation page can have 0 padding with some currencies #1780

Closed
kra-mo opened this issue Dec 17, 2024 · 5 comments
Closed

Donation page can have 0 padding with some currencies #1780

kra-mo opened this issue Dec 17, 2024 · 5 comments
Assignees
Labels
potential bug issues not yet tested
Milestone

Comments

@kra-mo
Copy link
Contributor

kra-mo commented Dec 17, 2024

Description

Making a good impression is very important when asking for money, so I feel like this is an important bug.

To Reproduce

  1. Set App Store location to a country with a currency of little value
  2. Open the App Store version of the app
  3. Open Settings
  4. Go to Donation page

Expected behavior

There is some horizontal padding of the page

CotEditor version

git main

macOS version

15.2

Additional context

No response

@kra-mo kra-mo added the potential bug issues not yet tested label Dec 17, 2024
@kra-mo
Copy link
Contributor Author

kra-mo commented Dec 17, 2024

I would upload a screenshot, but GitHub doesn't seem to like that right now for some reason.

The issue is probably there because the size of the page changes after going to it instead of having the size with the correct currency initially.

@1024jp
Copy link
Member

1024jp commented Dec 18, 2024

@kra-mo Thanks. Please share screenshots when the image uploading is available again.

@1024jp 1024jp self-assigned this Dec 18, 2024
@kra-mo
Copy link
Contributor Author

kra-mo commented Dec 18, 2024

Image

@1024jp
Copy link
Member

1024jp commented Dec 18, 2024

@kra-mo Thank you!
Well, I understand I need to update the layout. Let me consider.

@1024jp 1024jp added this to the 5.0.7 milestone Dec 18, 2024
@1024jp 1024jp closed this as completed in bf8fcb7 Dec 19, 2024
@1024jp
Copy link
Member

1024jp commented Dec 19, 2024

Fixed on CotEditor 5.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug issues not yet tested
Development

No branches or pull requests

2 participants