Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pageviews regression in 6.5.2 gem #1581

Closed
1 task done
steveng57 opened this issue Mar 1, 2024 · 2 comments
Closed
1 task done

Pageviews regression in 6.5.2 gem #1581

steveng57 opened this issue Mar 1, 2024 · 2 comments
Labels
wontfix This will not be worked on

Comments

@steveng57
Copy link

Checklist

How did you create the site?

Generated from chirpy-starter

Describe the bug

It seems that the post.html layout in the 6.5.2 gem does not have the pageviews code in it. It looks fine in 6.5.1.

If you download the 6.5.1 gem, you can see it in post.html around line 77. It is not there in the downloaded 6.5.2 gem.

It looks fine on github.

This means that it will work if you are on version 6.5.1 from the chirpy starter, and it will work if you are working from a fork. If you are working with the 6.5.2 gem from the chirpy starter, then it will not work.

It also means that the goatcounter stats are not being updated, as the javascript selector looks like it is missing the pageviews bits too.

Steps To Reproduce

  1. from the starter kit, work with 6.5.1
  2. enable all goatcounter settings in _config.yml
  3. verify that it works.
  4. upgrade to 6.5.2
  5. verify that pageviews no longer work

Expected Behavior

Pageviews on goatcounter should be updating.
Pageviews displays should be shown on post layouts.

Environment

Chirpy 6.5.2 from chirpy starter

Anything else?

No response

@kungfux
Copy link
Collaborator

kungfux commented Mar 1, 2024

Sorry for the misunderstanding. Pageviews on goatcounter #1543 was not planned to be released as part of the v6.5.1. This feature was not merged into the production branch, and it is not mentioned in the release notes for v.6.5.1. This was done by accident.

According to the release plan, it is planned for next major release.

@kungfux kungfux added the wontfix This will not be worked on label Mar 1, 2024
@steveng57
Copy link
Author

I see. I'll close it out then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants