You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the post.html layout in the 6.5.2 gem does not have the pageviews code in it. It looks fine in 6.5.1.
If you download the 6.5.1 gem, you can see it in post.html around line 77. It is not there in the downloaded 6.5.2 gem.
It looks fine on github.
This means that it will work if you are on version 6.5.1 from the chirpy starter, and it will work if you are working from a fork. If you are working with the 6.5.2 gem from the chirpy starter, then it will not work.
It also means that the goatcounter stats are not being updated, as the javascript selector looks like it is missing the pageviews bits too.
Steps To Reproduce
from the starter kit, work with 6.5.1
enable all goatcounter settings in _config.yml
verify that it works.
upgrade to 6.5.2
verify that pageviews no longer work
Expected Behavior
Pageviews on goatcounter should be updating.
Pageviews displays should be shown on post layouts.
Environment
Chirpy 6.5.2 from chirpy starter
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Sorry for the misunderstanding. Pageviews on goatcounter #1543 was not planned to be released as part of the v6.5.1. This feature was not merged into the production branch, and it is not mentioned in the release notes for v.6.5.1. This was done by accident.
According to the release plan, it is planned for next major release.
Checklist
How did you create the site?
Generated from
chirpy-starter
Describe the bug
It seems that the post.html layout in the 6.5.2 gem does not have the pageviews code in it. It looks fine in 6.5.1.
If you download the 6.5.1 gem, you can see it in post.html around line 77. It is not there in the downloaded 6.5.2 gem.
It looks fine on github.
This means that it will work if you are on version 6.5.1 from the chirpy starter, and it will work if you are working from a fork. If you are working with the 6.5.2 gem from the chirpy starter, then it will not work.
It also means that the goatcounter stats are not being updated, as the javascript selector looks like it is missing the pageviews bits too.
Steps To Reproduce
Expected Behavior
Pageviews on goatcounter should be updating.
Pageviews displays should be shown on post layouts.
Environment
Chirpy 6.5.2 from chirpy starter
Anything else?
No response
The text was updated successfully, but these errors were encountered: