Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VOTE] Change Bulma dependency to peerDependenc. and remove the import of the styles from this library #258

Closed
couds opened this issue Jun 8, 2020 · 2 comments

Comments

@couds
Copy link
Owner

couds commented Jun 8, 2020

Hi. I want to know what all of you think about removing the advanced configuration.

The Idea its to move Bulma to a peerDependency use this library only as a helper to add the bulma classes (Instead of also adding the css).

This is because all the issues are about Typescript or the advanced installation (Overwrite the variables)

Almost all frameworks now supports saas out of the box and it will be easier to the developers to follow the instructions of their frameworks to configure/modify their saas importation.

Obviously this will be a breaking change and will be done as a major release.

I will leave this post at least for a Month so all can vote

https://doodle.com/poll/mqqpxwkzm6nnrs3s

@couds couds pinned this issue Jun 8, 2020
@kennethnym
Copy link
Collaborator

Agreed. However, we need to have a version table that shows which bulma version should be used with which version of react-bulma-components, since sometimes we need to introduce new code to support new features in bulma.

@kennethnym kennethnym mentioned this issue Jun 27, 2020
37 tasks
@couds
Copy link
Owner Author

couds commented Jul 1, 2020

Not too many people voted, but all seem's to agree to this. so We sill go forward and change bulma to be a peerDependency. and remove all the sass import from this library.

@couds couds closed this as completed Jul 1, 2020
@kennethnym kennethnym unpinned this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants