Evaluate whether custom message queue is still needed #31
Comments
Krinkle
added a commit
that referenced
this issue
Oct 18, 2017
SmartIrc4net already has a built-in message queue with priority settings and processing in its own thread. Going through two layers of queues doesn't seem particularly valueable. Try to remove ours and see what happens. * Mapping isPriority=true -> Priority.High Mapping isPriority=false -> Priority.Low Unused for now Priority.Critical, Priority.Medium * Removing isDroppable for now. Fixes #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since the upgrade of Meebey.SmartIrc4net from 0.4 to 1.1 (e2d92e7), I think our custom message queue has become obsolete.
I disabled some of the more hacks that caused warnings in the new compiler after the upgrade, but I suspect the remaining custom code can be removed as well.
We currently have our own custom message queue thread, that continuously polls the high-priority and low-priority queues to send messages. And the thread is also disabled/resumed by our custom code based on how many bytes we've sent recently and when the last PING/PONG happened.
As far as I can see, this is all handled by SmartIrc4net and no longer requires us doing this. Would be good to try and get rid of it and see what happens.
The text was updated successfully, but these errors were encountered: