Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System.CommandLine instead of McMaster.Extensions.CommandLineUtils #1474

Closed
Bertk opened this issue May 16, 2023 · 7 comments
Closed

Use System.CommandLine instead of McMaster.Extensions.CommandLineUtils #1474

Bertk opened this issue May 16, 2023 · 7 comments
Labels
enhancement General enhancement request

Comments

@Bertk
Copy link
Collaborator

Bertk commented May 16, 2023

McMaster.Extensions.CommandLineUtils has a dependency System.ComponentModel.Annotations V5.0.0 and this package is deprecated.

see also natemcmaster/CommandLineUtils#533

Expected behavior
No deprecated package is used.

image

@Bertk Bertk changed the title Nuget package System.ComponentModel.Annotations V5.0.0 is deprecated Nuget package System.ComponentModel.Annotations V5.0.0 is deprecated (coverlet.console) May 16, 2023
@MarcoRossignoli
Copy link
Collaborator

@daveMueller we should move to https://learn.microsoft.com/en-us/dotnet/standard/commandline/

@MarcoRossignoli MarcoRossignoli added the enhancement General enhancement request label May 23, 2023
@Bertk Bertk changed the title Nuget package System.ComponentModel.Annotations V5.0.0 is deprecated (coverlet.console) Use System.CommandLine instead of McMaster.Extensions.CommandLineUtils Jun 3, 2023
@Bertk
Copy link
Collaborator Author

Bertk commented Jun 27, 2023

@MarcoRossignoli @daveMueller
The deprecated flag was removed from System.ComponentModel.Annotations V5.0.0
image

@Bertk Bertk closed this as completed Jun 27, 2023
@daveMueller
Copy link
Collaborator

daveMueller commented Jul 2, 2023

@MarcoRossignoli @petli even though the package isn't deprecated anymore should we still move to System.CommandLine?
The disadvantage is that System.CommandLine is still beta since 2 years and not sure if it will ever be officially released. @MarcoRossignoli maybe you got any insides on this?

However McMaster.Extensions.CommandLineUtils also is in maintenance mode https://github.com/natemcmaster/CommandLineUtils#project-origin-and-status and doesn't have much active development anymore.

We already have a PR for System.CommandLine here #1486 and I think it might be more futur-proof as it maybe becomes part of the sdk someday.

@Bertk
Copy link
Collaborator Author

Bertk commented Jul 3, 2023

Please note: System.CommandLine 2.0.0-beta4.23307.1 is also used from dotnet/sdk

Microsoft published the documentation here: https://learn.microsoft.com/en-us/dotnet/standard/commandline/

@MarcoRossignoli
Copy link
Collaborator

Let me get some information but I think it's fine use the preview.

@MarcoRossignoli
Copy link
Collaborator

@daveMueller I confirm that's good to merge also in preview, feel free to review and let me know if I can merge

@Bertk
Copy link
Collaborator Author

Bertk commented Aug 4, 2023

#1486 was merged

@Bertk Bertk closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants