Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All async methods seems to be excluded in coverlet.msbuild 2.8.1 #845

Closed
PolarbearDK opened this issue May 13, 2020 · 2 comments
Closed
Labels
needs more info More details are needed

Comments

@PolarbearDK
Copy link

PolarbearDK commented May 13, 2020

Just upgraded from coverlet.msbuild 2.6.3 to 2.8.1.
Report no longer shows coverage for any methods with the async keyword

This is the most simple example I could find in our code base:

public async Task<ConductedInterview[]> GetConductedInterviews(Guid citizenId)
{
  return (await GetInterviewInfo(citizenId)).Conducted;
}

The async methods were covered/not covered in 2.6.3.
With 2.8.1 they are ignored (grey in report).

@MarcoRossignoli
Copy link
Collaborator

Are you using /p:ExcludeByAttribute=CompilerGeneratedAttribute?Possible dup of #794

@MarcoRossignoli MarcoRossignoli added the needs more info More details are needed label May 14, 2020
@PolarbearDK
Copy link
Author

PolarbearDK commented May 15, 2020

We do indeed have that exclution. Looks much better without it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info More details are needed
Projects
None yet
Development

No branches or pull requests

2 participants