Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend tablet/mobile preview seems to beak CSS from the iFrame preview in 5.9.3 #59

Closed
covertnine opened this issue Apr 7, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@covertnine
Copy link
Owner

Hey,

Just noticed this on the latest update. I think it was from a 5.9.2 or 5.9.3 update, but it could just be in the regular 5.9 update. Basically, if you use the backend mobile/tablet previews, they break the CSS completely. There's no CSS applied from the custom-editor-style.css or the client-editor.css files.

I'm poking around trying to see what changed, but it may just be a matter of making sure the CSS files get inserted to the mobile previews, somehow.... any help would be appreciated here. Could be a theme thing to fix..

See screenshot--this is with latest block plugin/theme.

Screen Shot 2022-04-07 at 10 28 22 AM

-Tim

@covertnine covertnine added the bug Something isn't working label Apr 7, 2022
@covertnine
Copy link
Owner Author

Looks like it will take some code refactoring:
https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/applying-styles-with-stylesheets/

On the theme side I think I can handle the function updates to make sure the block editor CSS is pushing to the mobile previews, but would like some help on refactoring blocks if we need to stay compatible.

-Tim

@covertnine
Copy link
Owner Author

Looks like this is a bug other people are also dealing with so I'll just keep an eye on this one for now.

WordPress/gutenberg#38673
WordPress/gutenberg#39373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants