Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize IPFS Requests for App Data #2

Open
nlordell opened this issue Mar 31, 2022 · 2 comments
Open

Parallelize IPFS Requests for App Data #2

nlordell opened this issue Mar 31, 2022 · 2 comments

Comments

@nlordell
Copy link
Contributor

This iterative async block of code could probably be a batch request.

    for hash in uninitialized_app_data_hashes.iter() {
        download_referral_from_ipfs_and_store_in_referral_store(db.clone(), *hash).await?;
    }

cf referral_maintenance.rs

Original issue gnosis/gp-dune-bridge#59 by @bh2smith

@josojo
Copy link
Contributor

josojo commented May 30, 2022

Yes, this should be doable. Just a word of warning: When I was first implementing it, I had to fight with rate limitings. If we parallelize it, there is a risk that this will reappear

@bh2smith
Copy link
Contributor

To avoid the rate limiting (maybe) You can put a cap on the size of the batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants