Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't decode this image #77

Closed
satrio1256 opened this issue Jul 17, 2018 · 3 comments
Closed

Can't decode this image #77

satrio1256 opened this issue Jul 17, 2018 · 3 comments

Comments

@satrio1256
Copy link

satrio1256 commented Jul 17, 2018

For some strange reason, I couldn't decode this image.

screenshot from 2018-07-18 00-01-17

Would you mind to check? Thank you.

Edit :

  • Already trying with various angle and camera, still not working for me.. But the other qr (that I have) works perfectly.
  • Tested it with another scanner, it works there
@cozmo
Copy link
Owner

cozmo commented Jul 22, 2018

Hey! Thanks for the report. This is an interesting issue. Your QR code is missing the "terminator byte" which was believed to be required. That said, reading this makes it sound as if it's optional, and what is more, may be shorter than the 4 bytes we expect.

I made a PR (#80) to fix it, and have confirmed this fixes the above QR code, but I may want to change it a bit before merging depending on my rereading of the spec.

@satrio1256
Copy link
Author

Alright then. I'll wait for the final merge on the master branch.

Thanks for the follow-up :)

@cozmo
Copy link
Owner

cozmo commented Jul 24, 2018

This has been published on npm as 1.1.1. Thanks for the report, and sorry for the trouble. Going to close this issue but if for some reason there's still an issue please feel free to re-open.

@cozmo cozmo closed this as completed Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants