From bed74003528adceb23acaabd1a6b420a9161923e Mon Sep 17 00:00:00 2001
From: Alwyn Tan <alwyn.tan@data.gov.sg>
Date: Sun, 4 Mar 2018 10:03:08 +0800
Subject: [PATCH] mockResponse - tests to verify `write()` and `end()` with
 payloads

* Declare a new getter `_getChunks`, for testing purposes
* Add javadoc for  `_getBuffer`
* Add a suite of tests that ensure that calls to `write` and `end` with payloads
result in the correct state of `_data`, `_chunks` and `_buffer`. Ensure that methods
are tested in isolation, using a separate suite for interactions between `write` and `end`
---
 lib/mockResponse.js           | 19 +++++++-
 test/lib/mockResponse.spec.js | 81 +++++++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+), 1 deletion(-)

diff --git a/lib/mockResponse.js b/lib/mockResponse.js
index 041b816..d3327f9 100644
--- a/lib/mockResponse.js
+++ b/lib/mockResponse.js
@@ -40,7 +40,7 @@ function createResponse(options) {
     var _data = '';
     var _buffer = new Buffer(0);
     var _chunks = [];
-    var _size = 0; 
+    var _size = 0;
     var _encoding = options.encoding;
 
     var _redirectUrl = '';
@@ -676,10 +676,27 @@ function createResponse(options) {
         return _data;
     };
 
+    /**
+     * Function: _getBuffer
+     *
+     *  The buffer containing data to be sent to the user.
+     *  Non-empty if Buffers were given in calls to write() and end()
+     */
     mockResponse._getBuffer = function() {
         return _buffer;
     };
 
+
+    /**
+     * Function: _getChunks
+     *
+     *  The buffer containing data to be sent to the user.
+     *  Non-empty if Buffers were given in calls to write() and end()
+     */
+    mockResponse._getChunks = function() {
+        return _chunks;
+    };
+
     /**
      * Function: _getStatusCode
      *
diff --git a/test/lib/mockResponse.spec.js b/test/lib/mockResponse.spec.js
index 1fd3444..1b0a8a1 100644
--- a/test/lib/mockResponse.spec.js
+++ b/test/lib/mockResponse.spec.js
@@ -846,6 +846,46 @@ describe('mockResponse', function() {
     });
 
     describe('.write()', function() {
+      var response;
+
+      beforeEach(function() {
+        response = mockResponse.createResponse();
+      });
+
+      it('should accept a string and hold it in _data', function() {
+        var payload1 = 'payload1';
+        var encoding = 'utf8';
+        response.write(payload1, encoding);
+        expect(response._getData()).to.equal(payload1);
+        expect(response.getEncoding()).to.equal(encoding);
+      });
+
+      it('should accept multiple strings and concatenate them in _data', function() {
+        var payload1 = 'payload1';
+        var payload2 = 'payload2';
+        response.write(payload1);
+        response.write(payload2);
+        expect(response._getData()).to.equal(payload1 + payload2);
+      });
+
+      it('should accept a buffer and hold it in _chunks', function() {
+        var payload1 = 'payload1';
+        response.write(new Buffer(payload1));
+        var chunks = response._getChunks();
+        expect(chunks.length).to.eql(1);
+        expect(chunks[0].toString()).to.equal(payload1);
+      });
+
+      it('should accept multiple buffers and hold them in _chunks', function() {
+        var payload1 = 'payload1';
+        var payload2 = 'payload2';
+        response.write(new Buffer(payload1));
+        response.write(new Buffer(payload2));
+        var chunks = response._getChunks();
+        expect(chunks.length).to.eql(2);
+        expect(chunks[0].toString()).to.equal(payload1);
+        expect(chunks[1].toString()).to.equal(payload2);
+      });
 
       it('should inherit from Node OutogingMessage.write()');
 
@@ -871,12 +911,53 @@ describe('mockResponse', function() {
         expect(emits).to.eql(1);
       });
 
+      it('writes to _data if a string is supplied', function() {
+        var payload1 = 'payload1';
+        var encoding = 'utf8';
+        response.end(payload1, encoding);
+        expect(response._getData()).to.equal(payload1);
+        expect(response.getEncoding()).to.equal(encoding);
+      });
+
+      it('writes to _buffer if a Buffer is supplied', function() {
+        var payload1 = 'payload1';
+        response.end(new Buffer(payload1));
+        var buffer = response._getBuffer();
+        expect(buffer.toString()).to.equal(payload1);
+      });
+
       it('should inherit from Node OutogingMessage.end()');
 
     });
 
   });
 
+  describe('write() + end() interactions', function() {
+    var response;
+
+    beforeEach(function() {
+      response = mockResponse.createResponse();
+    });
+
+    it('should accept strings through write() and end() and concatenate them in _data', function() {
+      var payload1 = 'payload1';
+      var payload2 = 'payload2';
+      response.write(payload1);
+      response.end(payload2);
+      expect(response._getData()).to.equal(payload1 + payload2);
+    });
+
+    it('should accept buffers through write() and end() and concatenate them in _buffer', function() {
+      var payload1 = 'payload1';
+      var payload2 = 'payload2';
+      response.write(new Buffer(payload1));
+      response.end(new Buffer(payload2));
+      var buffer = response._getBuffer();
+      expect(buffer.toString()).to.equal(payload1 + payload2);
+    });
+
+  });
+
   // TODO: fix in 2.0; methods should be inherited from Node WritableStream
   describe('node WritableStream methods', function() {