Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Sources sidebar not accessible via keyboard [A11y] #15876

Closed
jakobhaerter opened this issue Oct 10, 2024 · 3 comments
Closed

[5.x]: Sources sidebar not accessible via keyboard [A11y] #15876

jakobhaerter opened this issue Oct 10, 2024 · 3 comments
Assignees
Labels

Comments

@jakobhaerter
Copy link

What happened?

Description

The sources sidebar is focusable but pressing space or enter does not change the view. A JS error is being thrown.

Image

Steps to reproduce

  1. Go to the entries view
  2. Navigate to the sources sidebar via the keyboard
  3. Try to open a tab with the space or enter key

Expected behavior

Pressing space or enter should update the view.

Actual behavior

No view update but a JS error inside the console.

Craft CMS version

5.4.5.1

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Oct 10, 2024

Hi, thanks for reporting! I raised a PR for this.

@brandonkelly
Copy link
Member

Craft 5.4.8 is out with that fix. Thanks again!

@jakobhaerter
Copy link
Author

Thank you, @i-just & @brandonkelly! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants