Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Sort icon is missing for ordering #15897

Closed
FrDH opened this issue Oct 16, 2024 · 6 comments
Closed

[5.x]: Sort icon is missing for ordering #15897

FrDH opened this issue Oct 16, 2024 · 6 comments
Assignees
Labels

Comments

@FrDH
Copy link
Contributor

FrDH commented Oct 16, 2024

What happened?

Description

For any overview that can be ordered, the icons that should indicate selected ordering isn't showing.
Image

Also, it would be very usefull if a page load would not reset the selected ordering.

Steps to reproduce

  1. Go to the CP > settings > entry types
  2. Do not notice the entry types can be ordered because of the missing icon
  3. Order the entry types by clicking on the "handle" table heading
  4. refresh the page

Expected behavior

Actual behavior

Craft CMS version

5

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

No response

@FrDH FrDH added the bug label Oct 16, 2024
@FrDH FrDH changed the title [5.x]: Sort icon is missing for ordering entry types [5.x]: Sort icon is missing for ordering Oct 16, 2024
@FrDH
Copy link
Contributor Author

FrDH commented Oct 16, 2024

screenshot of the missing icon:
Image

@i-just
Copy link
Contributor

i-just commented Oct 16, 2024

Hi, thanks for reporting. I raised a PR to align the styles of those headers with the element index tables and to show the relevant arrow icon when the column is sorted.

A couple of things to note:

  • The tables, like the Entry Types table, don’t store the selected sort options, so when you reload, the order goes back to the defaults
  • The screenshot you shared looks to be from an Entries index page for a structure? Structures are ordered by the custom order of the entries in it, and they support drag and drop to reorder (that’s why you can see the diamond icon to the left of the “Homepage”). You can switch to the regular table view, and then you’ll be able to sort by various headings (icons above the table, to the right of the search input).

@FrDH
Copy link
Contributor Author

FrDH commented Oct 18, 2024

Thank you foryour reply.

The screenshot was indeed of an Entries index page, but the same issue applies to (for example) cp/settings/entry-types and cp/settings/fields. Both tables can be ordered by clicking the table heading but do not show the corresponding sort-icon.

One last note, is there a reason the table in cp/settings/sections can't be sorted (we don't use "general", "categories" or "tags" so I don't know about those)?

@i-just
Copy link
Contributor

i-just commented Oct 22, 2024

One last note, is there a reason the table in cp/settings/sections can't be sorted

Thanks for the suggestion! We’re making the table on the sections index page sortable in 5.5.

@brandonkelly
Copy link
Member

Craft 4.12.8 and 5.4.9 are out with the updated table header styling to reveal when an admin table column is being sorted on.

@brandonkelly
Copy link
Member

Craft 5.5.0 is out with the ability to sort sections in the Sections index page 🎉 (#15936)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants