Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with go 1.17 #57

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Build with go 1.17 #57

merged 2 commits into from
Nov 2, 2021

Conversation

andrei-radulescu
Copy link
Contributor

@unguiculus
Copy link
Member

Thanks, you will also have to update release.yaml and go.mod.

@andrei-radulescu
Copy link
Contributor Author

andrei-radulescu commented Nov 2, 2021

Thanks, you will also have to update release.yaml and go.mod.

done (although it would have worked like this as well - done it for mozilla sops) :) watch out for go.sum as go 1.17 states also all indirect requirements in the go.sum and the magefile needs an extra annotation for it to run under go 1.17

@unguiculus unguiculus changed the title Build with go 1.17 to reduce vulnerabilities Build with go 1.17 Nov 2, 2021
@unguiculus
Copy link
Member

I changed the PR title because the CVE is not a reason to update. The fix was back-ported to 1.16.9. Anyways, updating is a good idea 😉.

@unguiculus unguiculus merged commit a7ffaeb into craftypath:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants