Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't correct iif to if #763

Open
tekumara opened this issue Jun 24, 2023 · 3 comments
Open

Don't correct iif to if #763

tekumara opened this issue Jun 24, 2023 · 3 comments
Labels
enhancement Improve the expected

Comments

@tekumara
Copy link
Contributor

because iif is a sql function name (eg: in sqlite)

@not-my-profile
Copy link
Contributor

I think we should still correct it by default because I think in codebases in general it's likely to be a typo. If your codebase uses that SQLite function, you can just add it to default.extend-identifiers.

@aspizu
Copy link

aspizu commented Sep 6, 2023

Or detect if the file is SQL, or part of a string SQL query.

@epage
Copy link
Collaborator

epage commented Sep 6, 2023

btw with #793 we more easily support per-filetype dictionaries (see #794).

If the sql file type would catch enough of these cases, I'm fine if someone adds that into there.

We currently nor do I have plans for detecting nested languages, so us handling SQL queries inside of files is unlikely to happen

@epage epage added the enhancement Improve the expected label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

4 participants