feat!: Allow downstream users to avoid the precomputations that are needed for the FixedBaseMSM algorithm in FK20 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
changed the title
kevaundray
commented
Aug 15, 2024
This was referenced Aug 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Users now need to specify whether they want to use Precomp or not, if calling DasContext::with_threads. To preserve the previous behaviour, one can pass
UsePrecomp::Yes{width:8}Its also breaking because the
Default::defaultmethod no longer creates the precomputations. This was changed because the Default::default method was using up 100MB of data, and we want the user to intentionally opt into this.Note
In the future, we may be able to allow the user to specify a memory-limit and we compute the width parameter based off of that, but this seems like a non-goal right now