-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy Context API / findDomNode usage #91
Comments
Hello again, @Wintereise , Yes, we are going to update our products to the v4 of Material-UI. But you have to understand, and I am not trying to be rude here, I am just trying to explain how we work at Creative-Tim - no offense intended, that beside this project, we have 11 other products that we also have to maintain, and also, while doing this we have to work on developing new products. I hope I've asked your question. I have although one question, you say something about the PRO version in your comment, you also checked the I'm reporting the issue to the correct repository (for multi-repository projects). Why did you open this issue here, and not on the PRO repository? All the best, Trying to help the open source community:
If you've liked what you saw, help me with a comment, like, share or subscribe. |
In the next major update, please develop with React strict mode. |
Hey @einazare,
Fair enough, my intention wasn't to ask "why hasn't it been done yet (doing it already makes no sense, mui v4 is beta software)," but simply to understand if CT had plans to do so. Regarding the challenges, I fully understand. Thank you for providing the timeline.
That would be because I infact did not know that mdr had multiple repos. I googled it, found this repo, opened issues, found the other one afterwards ┐(´∀`)┌ヤレヤレ |
Ok, so then it will take us more than 1-3 months. I'll discuss this with our board. |
Hello again, @Wintereise ,
You can get the right repo link from our website (from the comments section on the product page), or from our live docs. |
Do you have a source on that? According to the blog post We can pretty much still use JSS logic with hooks. |
I do not remember where I read that. |
Prerequisites
Please answer the following questions for yourself before submitting an issue.
I'm a material dashboard react pro subscriber with current premium support.
The theme (thanks to material-ui 3.x usage) makes use of the legacy context API (which has been marked as deprecated) and findDomNode, both of which cause problems if one turns on React's
StrictMode
and are marked for removal sometime in the future.material-ui is going to be fixing these in their 4.x release, will this theme be seeing that update?
Relevant MUI issues.
The text was updated successfully, but these errors were encountered: