Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config purged from arm-unknown-linux-gnueabihf #422

Closed
jmagnuson opened this issue May 6, 2020 · 1 comment · Fixed by #424
Closed

pkg-config purged from arm-unknown-linux-gnueabihf #422

jmagnuson opened this issue May 6, 2020 · 1 comment · Fixed by #424

Comments

@jmagnuson
Copy link
Contributor

pkg-config is getting removed in the apt-get purge, even though it was explicitly installed in common.sh:

https://dev.azure.com/rust-embedded/cross/_build/results?buildId=576&view=logs&j=ed13e0de-1834-5225-9caa-5c6f5a5a1fa1&t=91dd8e19-28bc-5135-e5ed-520472032e91&l=2665

But on armv7-unknown-linux-gnueabihf for instance, this is not happening:

https://dev.azure.com/rust-embedded/cross/_build/results?buildId=576&view=logs&j=36c4a3c9-c17a-548c-f0e4-0d2902437e43&t=26e6497a-1b48-5743-221f-9d1b01950b2c&l=4078

And testing locally:

$ docker run rustembedded/cross:arm-unknown-linux-gnueabihf which pkg-config || echo "not found"
not found

$ docker run rustembedded/cross:armv7-unknown-linux-gnueabihf which pkg-config
/usr/bin/pkg-config
@jmagnuson
Copy link
Contributor Author

The toolchain installation doesn't apply the same prune filtering that the other dependency shell scripts do--

https://github.com/rust-embedded/cross/blob/8a2f734bb0b422f131b73f1a3804777cb3cf8392/docker/Dockerfile.arm-unknown-linux-gnueabihf#L17

pkg-config depends on xz-utils, both of which end up getting removed.

Any objection to just removing that entry/line? Curl seems useful to have as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants