Implement Cross.toml deserialization using serde
#670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can split the documentation out into it's own .md and then do #![doc = include_str!("file.md")] |
|
Thanks for the prompt review, @Emilgardis! I made the suggested changes and split out the documentation in a separate .md file. |
Emilgardis
requested changes
Mar 22, 2022
Emilgardis
previously approved these changes
Mar 22, 2022
There was a problem hiding this comment.
this is great 😄 thank you!
I want to merge #624 as well, but I think it makes sense to merge this before
please address the remaining clippy issues and add a simple changelog entry and I'll r+ this!
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Apr 7, 2022
683: fix env r=reitermarkus a=Emilgardis Fixes a wrong assumption done in #670 where we went from ```toml [target.aarch64-unknown-linux-gnu.env] volumes = [ "BUILD_DIR", ] ``` to ```toml [target.aarch64-unknown-linux-gnu] volumes = [ "BUILD_DIR", ] ``` this fixes that, and makes sure that all markdown toml fences are checked in CI for correctness. This pr also "un-opts" what was previously `CrossBuildConfig` to simplify a bit, see #670 (comment) Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
Alexhuszagh
added
the
no-ci-targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the deserialization of the
Cross.tomlconfig usingserde. It can therefore be seen as some preliminary work on the issues #657, #664, and is related to #532 on #624.I added some basic documentation as module-level documentation, although I'm not sure whether this is the best place for that. Ideally it should be documentated in the
README.mdat some point. Furthermore,CrossTomllives in its own module, but a more suitable place might be theconfigmodule.