Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth is not working in electron #56

Open
cbleek opened this issue Feb 26, 2020 · 0 comments
Open

OAuth is not working in electron #56

cbleek opened this issue Feb 26, 2020 · 0 comments

Comments

@cbleek
Copy link
Member

cbleek commented Feb 26, 2020

OAuth in a Webpage is working by simply add the APP_ID to the hellojs request. The OAuth provider can check the domain of a requesting service, to ensure the authentication on an application level. If an application is running in electron mode, the domain is localhost, which cannot be mapped to a responsible person.

Therefore it is probably necessary to send the secret in the hellojs requests.

but maybe I'm wrong

created because of #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant