-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter empty length key diffs in Storage Account resource #816
Filter empty length key diffs in Storage Account resource #816
Conversation
/test-examples="examples/storage/v1beta1/account.yaml" |
@nitang22, Would you be willing to test this PR in your local environment with your resource manifest? The manifest I prepared for Uptest fails and I don't have a local environment handy to test. |
@mergenci Sure, however, I will need some guidance for the test, is there any documentation on how I can compile your code ? |
0798054
to
04b137b
Compare
@nitang22, I don't think we have an up-to-date documentation for local development. So, I found it easier to set up my local Azure environment 🙂 The PR fixes the issues. I need more time to work on an example manifest for automated tests. Until we release a new version, you can use the following monolith image to test in your environment: index.docker.io/mergenci/provider-azure:v1.6.0-rc-pr-816-04b137b I published a monolith image, which includes all family providers in one package, because installing a family provider requires installing dependencies, which is difficult with a third-party repository. Monolith provider doesn't have any dependencies, so you can install it by itself. |
04b137b
to
4516caf
Compare
/test-examples="examples/storage/v1beta1/account.yaml" |
FYI, this PR seems to fix the issue. Can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mergenci, after fixing gocyclo failure or ignoring it like here, we can move PR forward.
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
4516caf
to
c6a32bc
Compare
Thanks for letting me know @turkenf. I acted out of my prejudice against linter usually failing and didn't check why it failed 😒 Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mergenci, LGTM.
Successfully created backport PR #826 for |
Description of your changes
Fixes #683, #807
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
See minimally-working example manifest's Uptest result.
Example manifest, which is introduced by this PR, won't reproduce the linked issues above. Therefore, apply the following manifest to reproduce the error: