Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumers are "forced" to use gopkg.in/alecthomas/kingpin.v2 #62

Closed
gravufo opened this issue Apr 19, 2024 · 1 comment · Fixed by #63
Closed

Consumers are "forced" to use gopkg.in/alecthomas/kingpin.v2 #62

gravufo opened this issue Apr 19, 2024 · 1 comment · Fixed by #63
Labels
bug Something isn't working

Comments

@gravufo
Copy link
Contributor

gravufo commented Apr 19, 2024

What happened?

Go projects that reference this project are (almost) forced to use gopkg.in/alecthomas/kingpin.v2 instead of github.com/alecthomas/kingpin/v2.

How can we reproduce it?

Take any project that references this one in its go.mod and try to use github.com/alecthomas/kingpin/v2 in the sub project with a replace such as this:
replace gopkg.in/alecthomas/kingpin.v2 v2.2.6 => github.com/alecthomas/kingpin/v2 v2.4.0

then:

❯ go mod why -m all          
go: github.com/alecthomas/kingpin/v2@v2.4.0 used for two different module paths (github.com/alecthomas/kingpin/v2 and gopkg.in/alecthomas/kingpin.v2)

This returns an exit code of 1, which makes scanning tools (such as Black Duck) fail their scan. This is why it makes it "impossible" for consumers to use the newer module version of kingpin.

What environment did it happen in?

Go version: 1.22

@gravufo
Copy link
Contributor Author

gravufo commented May 16, 2024

Thank you @negz !
Any chance of taking a look at pretty much the same things in other repos?

In order (upjet needs to be merged first):
crossplane/upjet#389
crossplane-contrib/provider-kubernetes#231
crossplane-contrib/provider-upjet-azure#714

Little unlelated, but still close enough:
crossplane-contrib/provider-kubernetes#225

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant