Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically fieldpath.Pave composite and composed resources #34

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

negz
Copy link
Member

@negz negz commented Sep 29, 2023

Description of your changes

Fixes #33

This makes it more convenient and discoverable to get and set arbitrary unstructured data from a composed or composite resource.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

I updated function-patch-and-transform to use this SDK, and it works as expected.

This makes it more convenient and discoverable to get and set arbitrary
unstructured data from a composed or composite resource.

Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
We don't need the GetUnstructured interface since any type that has it
embeds Unstructured, and lets us get its object directly.

Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
@negz negz requested a review from phisco September 29, 2023 05:14
@negz
Copy link
Member Author

negz commented Sep 29, 2023

@phisco FYI, in case you want to retroactively review 😅. I'm going to merge this one because we have a bunch of @upbound folks hacking on Functions tomorrow and I think this will make life easier.

@negz negz merged commit bb85756 into crossplane:main Sep 29, 2023
7 checks passed
@negz negz deleted the pavement branch September 29, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically fieldpath.Pave unstructured resources
1 participant