Cope better with different/multiple Crosswalk Android versions

[townxelliot]

Issue by townxelliot from Wednesday Jan 22, 2014 at 09:55 GMT

---

At the moment, the xwalk_apkgen tool is tailored to a particular Crosswalk Android version (currently: 4.*). This means that it breaks if you try to use it with a different version. (This is because, by design, we try to be selective for the sake of speed, and don't scan for files or include all the .jar or .so files in xwalk_app_template; but this makes the tool brittle if the structure of xwalk_app_template changes.)

There are three ways we could cope with this:

1. Release different versions of the tool for different Crosswalk Android versions, and make it fail noisily if an unsupported version is used. This is the quick but dirty approach.
2. Modify the tool to support different Crosswalk Android versions. This would need some kind of map adding to Env.configure() so we can find the right components from Crosswalk Android, depending on the version being used. This would need more coding, but be more flexible and cleaner.
3. Scan for files rather than try to selectively locate them. This is the current make_apk.py approach. This would be slower and more flexible, but could introduce errors (e.g. if there are files in the xwalk_app_template which should not be in the apk file).