Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the JavaScript File Export Options #295

Closed
andrii-bodnar opened this issue Aug 10, 2023 · 5 comments · Fixed by #305
Closed

Add the JavaScript File Export Options #295

andrii-bodnar opened this issue Aug 10, 2023 · 5 comments · Fixed by #305
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

Crowdin recently added the ability to configure the export options for JavaScript files. This is a great feature, but it's not yet supported by the API Client.

  • exportPattern - string, File export pattern. Defines file name and path in resulting translations bundle.
  • exportQuotes - string enum single or double. Defines quotes to be used in resulting translations bundle.

The new options need to be added to this API Client.

API Reference:

@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers labels Aug 10, 2023
@andrii-bodnar andrii-bodnar added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Sep 13, 2023
@balogun14
Copy link
Contributor

@andrii-bodnar can you explain this issue more I will like to work on this

@andrii-bodnar
Copy link
Member Author

@balogun14
Copy link
Contributor

@andrii-bodnar
Copy link
Member Author

@balogun14 yes, but please also check the other places including Unit tests. There might be more files required to be changed for this feature

@balogun14
Copy link
Contributor

@andrii-bodnar okay i will start working on this now

@andrii-bodnar andrii-bodnar linked a pull request Oct 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants