Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Pre-Translation API: add labels support #302

Closed
andrii-bodnar opened this issue Sep 13, 2023 · 7 comments · Fixed by #306
Closed

Apply Pre-Translation API: add labels support #302

andrii-bodnar opened this issue Sep 13, 2023 · 7 comments · Fixed by #306
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest

Comments

@andrii-bodnar
Copy link
Member

Crowdin has recently added a possibility to Pre-Translate strings by labels. However, the new parameters are not supported in this API client.

The new labelIds and excludeLabelIds parameters should be added to the "Apply Pre-Translation" method in this API client.

API Reference:

@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest labels Sep 13, 2023
@KyleGrande
Copy link
Contributor

Hey! So does this just require an update to the PreTranslateRequest interface or am I misunderstanding?

@andrii-bodnar
Copy link
Member Author

Hi @KyleGrande, yes, it's related to the PreTranslateRequest, PreTranslationStatusAttributes, and probably something else related to the Pre-Translation including Unit tests (needs to be checked in the code).

@KyleGrande
Copy link
Contributor

Thanks @andrii-bodnar for further clarifying. I will look more into it and begin working.

@KyleGrande
Copy link
Contributor

@andrii-bodnar So, I've gone ahead and updated the PreTranslateRequest & PreTranslationStatusAttributes interfaces and now I'm looking to see what related to the unit test should be changed but I am kind of lost. Could you maybe point me in the right direction? I was thinking I needed to add test with labelIds and excludeLabelIds? I am currently looking at the test /crowdin-api-client-js/tests/translations and /crowdin-api-client-js/tests/translationStatus.

@andrii-bodnar
Copy link
Member Author

@KyleGrande I think it would be nice to add a new test case in the tests/translations/api.test.ts

@KyleGrande
Copy link
Contributor

KyleGrande commented Oct 5, 2023

@andrii-bodnar I believe this should be everything #306 , if not please let me know.

Also, thank you very much for guiding me through it.

@andrii-bodnar
Copy link
Member Author

@KyleGrande looks good to me, thanks a lot for the contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue welcomes contributions for Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants