-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Pre-Translation API: add labels support #302
Comments
Hey! So does this just require an update to the PreTranslateRequest interface or am I misunderstanding? |
Hi @KyleGrande, yes, it's related to the |
Thanks @andrii-bodnar for further clarifying. I will look more into it and begin working. |
@andrii-bodnar So, I've gone ahead and updated the |
@KyleGrande I think it would be nice to add a new test case in the tests/translations/api.test.ts |
@andrii-bodnar I believe this should be everything #306 , if not please let me know. Also, thank you very much for guiding me through it. |
@KyleGrande looks good to me, thanks a lot for the contribution! 🚀 |
Crowdin has recently added a possibility to Pre-Translate strings by labels. However, the new parameters are not supported in this API client.
The new
labelIds
andexcludeLabelIds
parameters should be added to the "Apply Pre-Translation" method in this API client.API Reference:
attributes
field now contains the new fields as well)The text was updated successfully, but these errors were encountered: