Separate mip-map generation into graphics utilities. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crud89
added
Requirement
|
Run: checks |
|
Run: checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Mip map generation is natively supported in Vulkan, but not in DirectX 12. To support it, the D3D12 backend required to store a whole pipeline state that can execute a custom mip-map generation logic. This introduced dependencies between the device and pipeline state resources.
This PR moves mip-map generation out of the backend implementation into the graphics library. This library was somewhat redundant anyway and now is an optional utility library, that needs to be linked explicitly in order to use it.