Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Refactor JMC related code when upstream refactoring is complete #173

Closed
Josh-Matsuoka opened this issue Feb 1, 2023 · 1 comment
Closed

[Task] Refactor JMC related code when upstream refactoring is complete #173

Josh-Matsuoka opened this issue Feb 1, 2023 · 1 comment
Assignees
@Josh-Matsuoka @aptmac
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file

Comments

@Josh-Matsuoka
Copy link
Contributor

Currently we're embedding classes from the flightrecorder, rjmx, jdp, and ui/common. There's an ongoing effort to refactor flightrecorder.configuration and ui.common into jmc-core. Once this upstream refactoring is done and the changes are available on maven central we should update cryostat accordingly.

Depends on the following upstream issues:
https://bugs.openjdk.org/browse/JMC-7308
https://bugs.openjdk.org/browse/JMC-7307

Related: #95 #22
@Josh-Matsuoka Josh-Matsuoka added dependencies Pull requests that update a dependency file chore Refactor, rename, cleanup, etc. labels Feb 1, 2023
@Josh-Matsuoka Josh-Matsuoka self-assigned this Feb 1, 2023
@ebaron ebaron mentioned this issue Feb 22, 2023
Closed
@andrewazores andrewazores mentioned this issue May 25, 2023
Closed
@aptmac aptmac mentioned this issue Dec 11, 2023
Closed
@aptmac aptmac mentioned this issue Mar 25, 2024
Merged
@aptmac aptmac mentioned this issue May 1, 2024
Merged
7 tasks
@aptmac aptmac self-assigned this May 1, 2024
@andrewazores andrewazores mentioned this issue Jul 2, 2024
Closed
@aptmac
Copy link
Member

aptmac commented Jul 18, 2024

Just noticed that there were a couple of issues still open related to the dependency on jmc/application.

This was addressed in commit 34c5e0e.

@aptmac aptmac closed this as completed Jul 18, 2024
@andrewazores andrewazores mentioned this issue Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Josh-Matsuoka Josh-Matsuoka

@aptmac aptmac

Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Josh-Matsuoka @aptmac