Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] EventTypeMetadataV2 embedded source fork is outdated #365

Closed
andrewazores opened this issue Apr 2, 2024 · 1 comment · Fixed by #362
Closed

[Bug] EventTypeMetadataV2 embedded source fork is outdated #365

andrewazores opened this issue Apr 2, 2024 · 1 comment · Fixed by #362
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

          I see two issues here, the good news is that one of them is already fixed and is just missing in cryostat-core.

2024-01-22 10:19:38,997 WARNING [org.ope.jmc.rjm.ser.jfr] (executor-thread-1) Inferred content type 'jdk.jfr.Period' for option Period

This was fixed in https://bugs.openjdk.org/browse/JMC-6141 (JMC 8.1.0), the problem looks to be that EventTypeMetadataV2 in cryostat-core didn't receive the change when it was updated to consume 8.2.0. The line at https://github.com/cryostatio/cryostat-core/blob/main/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/EventTypeMetadataV2.java#L55 will need to be updated like: openjdk/jmc@e34323d#diff-9aa914b001864ae2b91cba7f4382a652ffecb05275c650d54b2155658ee03865L55

2024-01-22 10:19:38,997 WARNING [org.ope.jmc.fli.configuration] (executor-thread-1) Couldn't find constraint for null

I put in some quick logging and it looks to be that when resolving contentType, jdk.settings.Throttle isn't being handled properly and falls through as null. I'll make a note to poke around here a bit more and open a bug upstream JMC side.

Originally posted by @aptmac in cryostatio/cryostat#249 (comment)

@andrewazores
Copy link
Member Author

This is technically a separate pre-existing issue, but it should get resolved by #362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant