Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom event template for report generation event #14

Closed
andrewazores opened this issue Jan 25, 2022 · 0 comments · Fixed by cryostatio/cryostat-core#261
Closed
Labels
feat New feature or request

Comments

@andrewazores
Copy link
Member

andrewazores commented Jan 25, 2022

-core has a ReportRuleEvalEvent JFR event that that we should be able to capture from sidecar report generators. The best way to do this should be something similar to what we do in main Cryostat with the cryostat.jfc template. Using the Profiling template provided by the JDK in the base image of this project, extend the template by adding an event definition for the ReportRuleEvalEvent. That updated template definition should be added to this project somewhere under src/main/resources, and the build configuration updated so that the event template file is copied into the built OCI image in the correct filesystem location.

This can probably be accomplished with the Maven assembly plugin, as seen here:

https://github.com/cryostatio/cryostat/blob/main/src/assembly/dist.xml

https://github.com/cryostatio/cryostat/blob/7361dfee2ed32920171ca6219406c94086d5f436/pom.xml#L894

The setup will vary somewhat however since main Cryostat uses Jib to build the OCI image, but here in -reports we use the quarkus docker image build plugin.

<artifactId>quarkus-container-image-docker</artifactId>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant