From 64c1753dc3f3bc8811b6f9322f06ccffb1929afc Mon Sep 17 00:00:00 2001 From: Andrew Azores Date: Fri, 31 May 2024 11:21:55 -0400 Subject: [PATCH 1/3] fix(custom-targets): remove restriction on k8s jfr-jmx/9091, explain localhost:0 --- guides/_subsections/create-a-custom-target.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/guides/_subsections/create-a-custom-target.md b/guides/_subsections/create-a-custom-target.md index 80eb0c6..338c60d 100644 --- a/guides/_subsections/create-a-custom-target.md +++ b/guides/_subsections/create-a-custom-target.md @@ -2,10 +2,12 @@ **Cryostat** automatically discovers `target` **JVMs** using various mechanisms (e.g. **Kubernetes API**, **JDP**, [Cryostat Agent plugin](#using-the-cryostat-agent)). -However, in some cases (e.g. for **Kubernetes API**, **JMX** port is not `9091` and -port name is not `jfr-jmx`), **Cryostat** might not see your applications. In these -scenarios you can tell **Cryostat** about them by filling out the *Custom Target* -form to specify *Custom Targets*. +However, in some cases **Cryostat** it may not be feasible or desirable to configure +your application to suit Cryostat's discovery requirements. In these scenarios you can +tell **Cryostat** about them by filling out the *Custom Target* form to specify +*Custom Targets*. This can also be used to have Cryostat register itself as a discovered +target by using the special value `localhost:0`, which informs Cryostat's JVM to +use a special JMX connection to itself without going through the network stack.
  1. From ce9e0ee3dffb478e43dddd93d983703f2a1aee39 Mon Sep 17 00:00:00 2001 From: Andrew Azores Date: Fri, 31 May 2024 11:22:10 -0400 Subject: [PATCH 2/3] provide more reasons connection test may fail --- guides/_subsections/create-a-custom-target.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/guides/_subsections/create-a-custom-target.md b/guides/_subsections/create-a-custom-target.md index 338c60d..c951095 100644 --- a/guides/_subsections/create-a-custom-target.md +++ b/guides/_subsections/create-a-custom-target.md @@ -59,7 +59,13 @@ use a special JMX connection to itself without going through the network stack.
    An exclamation mark and an alert banner will show if an error - occurs while connecting to the target. + occurs while connecting to the target. This may + occur if the URL is incorrect due to incorrect hostname or + port number, or if the port is blocked by a firewall or network + policy, or if the JVM listening on the specified port requires + JMX credentials that Cryostat does not have in its keyring, or + if the JVM listening on the specified port presents an SSL/TLS + certificate which Cryostat does not trust.

    From 2b2a2fe54e45b08212d6e135dfc2fe706b01b15d Mon Sep 17 00:00:00 2001 From: Andrew Azores Date: Fri, 31 May 2024 13:47:15 -0400 Subject: [PATCH 3/3] formatting --- guides/_subsections/create-a-custom-target.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/guides/_subsections/create-a-custom-target.md b/guides/_subsections/create-a-custom-target.md index c951095..45c140e 100644 --- a/guides/_subsections/create-a-custom-target.md +++ b/guides/_subsections/create-a-custom-target.md @@ -1,13 +1,14 @@ ## [Create a Custom Target](#create-a-custom-target) -**Cryostat** automatically discovers `target` **JVMs** using various mechanisms (e.g. -**Kubernetes API**, **JDP**, [Cryostat Agent plugin](#using-the-cryostat-agent)). -However, in some cases **Cryostat** it may not be feasible or desirable to configure -your application to suit Cryostat's discovery requirements. In these scenarios you can -tell **Cryostat** about them by filling out the *Custom Target* form to specify -*Custom Targets*. This can also be used to have Cryostat register itself as a discovered -target by using the special value `localhost:0`, which informs Cryostat's JVM to -use a special JMX connection to itself without going through the network stack. +**Cryostat** automatically discovers `target` **JVMs** using various mechanisms +(e.g. **Kubernetes API**, **JDP**, [Cryostat Agent plugin](#using-the-cryostat-agent)). +However, in some cases it may not be feasible or desirable to configure your +application to suit **Cryostat**'s discovery requirements. In these scenarios +you can tell **Cryostat** about them by filling out the *Custom Target* form to +specify *Custom Targets*. This can also be used to have **Cryostat** register +itself as a discovered target by using the special value `localhost:0`, which +informs **Cryostat**'s **JVM** to use a special **JMX** connection to itself +without going through the network stack.