Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashboard.json #89

Closed
andrewazores opened this issue Nov 12, 2021 · 0 comments · Fixed by #91
Closed

Remove dashboard.json #89

andrewazores opened this issue Nov 12, 2021 · 0 comments · Fixed by #91
Labels
build good first issue Good for newcomers

Comments

@andrewazores
Copy link
Member

dashboard.json is not used by the jfr-datasource directly. It is intended to be imported into a Grafana Dashboard instance which is also configured with a jfr-datasource instance as a datasource. The Cryostat Grafana Dashboard container image bakes in the dashboard.json already, and any updates to the default Cryostat dashboard should be done there and not here. So, the dashboard.json definition in this project should be removed as it is now obsolete and redundant.

See #38 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant