You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just notice before if you called mount twice on same DOM element, you had an unmount to deal with it. Now it is possible to mount twice, or more. Shouldn't you just check if mounted, and don't re.mount again if mounted?
And it's faster processing a number then a string, so why not validate if the mount id is a number? And have a fast quick up for backing out if the node is something like a window, document, or text node, none of which support attributes or a .getAttribute method? Just to gain better performance?
The text was updated successfully, but these errors were encountered:
Otherwise I don't think we have the same issues as React in general. And attributes and properties are manged in a separate way. So all updating an attribute would just work fine.
I just notice before if you called mount twice on same DOM element, you had an unmount to deal with it. Now it is possible to mount twice, or more. Shouldn't you just check if mounted, and don't re.mount again if mounted?
And it's faster processing a number then a string, so why not validate if the mount id is a number? And have a fast quick up for backing out if the node is something like a window, document, or text node, none of which support attributes or a .getAttribute method? Just to gain better performance?
The text was updated successfully, but these errors were encountered: