Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling mount twice etc. #33

Closed
ghost opened this issue May 26, 2015 · 3 comments
Closed

calling mount twice etc. #33

ghost opened this issue May 26, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented May 26, 2015

I just notice before if you called mount twice on same DOM element, you had an unmount to deal with it. Now it is possible to mount twice, or more. Shouldn't you just check if mounted, and don't re.mount again if mounted?

And it's faster processing a number then a string, so why not validate if the mount id is a number? And have a fast quick up for backing out if the node is something like a window, document, or text node, none of which support attributes or a .getAttribute method? Just to gain better performance?

@ghost
Copy link
Author

ghost commented May 26, 2015

React fails to unmount a tree inside a event handler, is this a issue with dom-layer? facebook/react#3298

@ghost
Copy link
Author

ghost commented May 26, 2015

Also check if this is a issue for dom-layer: facebook/react#3799

@jails
Copy link
Contributor

jails commented May 26, 2015

I reenabled the "auto unmount" feature e6f65c2

Otherwise I don't think we have the same issues as React in general. And attributes and properties are manged in a separate way. So all updating an attribute would just work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant