Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure OpenFileInAppProvider in OCM shares gets correct username #1198

Closed
glpatcern opened this issue Sep 26, 2020 · 1 comment
Closed

Comments

@glpatcern
Copy link
Member

So this is not forgotten as a remaining issue from #1140.

Comment from @ishank011: can't do that with the current implementation. We're passing the same token around as the original user and can't make changes to it as we don't know the jwt secret of the other site. This won't be an issue in the public shares implementation so I think we can leave it be.
#1140 (comment)_

Not sure I understand why public shares won't be affected - in public shares, username essentially is "anonymous". Conversely, one of the key advantages of federated (OCM) shares is the ability to support federated identities.

@glpatcern
Copy link
Member Author

This was fixed as part of the large refactoring around the OCM implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant