Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GET range-requests in the file system layer #1395

Open
ishank011 opened this issue Jan 12, 2021 · 3 comments
Open

Handle GET range-requests in the file system layer #1395

ishank011 opened this issue Jan 12, 2021 · 3 comments

Comments

@ishank011
Copy link
Contributor

Range-based downloads should be handled by the file systems. Instead of transporting large files to the ocdav layers for small ranges, these should be truncated earlier as per the functionalities provided by the fs.

@butonic
Copy link
Contributor

butonic commented Jan 12, 2021

um did I miss anything in #1388?

@butonic
Copy link
Contributor

butonic commented Jan 12, 2021

Ah, you are talking about the storage interface.

@ishank011
Copy link
Contributor Author

ishank011 commented Jan 12, 2021

@butonic yep, currently we read the complete file from the file system and truncate it later. We were discussing the possibility of having this functionality in EOS so as to avoid streaming the whole file. So different file systems would handle it differently (they already do so for range-based uploads via tus), so it makes sense to move this implementation detail there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants