Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId idp may have prefix #2288

Open
michielbdejong opened this issue Nov 17, 2021 · 2 comments
Open

UserId idp may have prefix #2288

michielbdejong opened this issue Nov 17, 2021 · 2 comments

Comments

@michielbdejong
Copy link
Contributor

The idp field of a UserId should identify the identity provider of the user, but it's unclear from the current documentation of cs3apis whether this should be done with a domain (e.g. 'cernbox.cern.ch') or with an origin (e.g. 'https://cernbox.cern.ch').

Recently, the users.demo.json file in the ocmd example switched from the first to the second format.

In cs3org/cs3apis#159 I proposed to make the second format the prescribed one, but we don't want to make this a breaking change, so reva should start supporting origin-format for userid idp in addition to supporting domain-format as it does currently.

We should to make the provider authorizer interceptor accept both formats, I'll create a PR.

@redblom
Copy link
Contributor

redblom commented Aug 22, 2022

@michielbdejong We want to finalize this (in the context of #3121).
Can you confirm that the proposed format of the idp field, as origin (eg. https://cernbox.cern.ch) is definite ?

@michielbdejong
Copy link
Contributor Author

In cs3org/cs3apis#159 (comment) @wkloucek proposed a 3rd option, namely a full URL. So the options are:

  1. domain, e.g. "cernbox.cern.ch"
  2. origin, e.g. "https://cernbox.cern.ch"
  3. full URL, e.g. "https://cernbox.cern.ch/some/path"

I'm OK with whatever you prefer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants