Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect role after accessing a public link with Uploader role #2521

Open
gmgigi96 opened this issue Feb 8, 2022 · 0 comments
Open

Incorrect role after accessing a public link with Uploader role #2521

gmgigi96 opened this issue Feb 8, 2022 · 0 comments

Comments

@gmgigi96
Copy link
Member

gmgigi96 commented Feb 8, 2022

The role in the scope set by reva in a public share link is incorrect when created with Uploader role. It is editor, but should be uploader.
I think this is due to the fact that in the publicshares auth manager. the only permission checked is InitiateFileUpload and assigned an editor role, while the correct check should be:

  • if InitiateFileDownload and InitiateFileUpload are set => editor role
  • if only InitiateFileUpload is set => uploader role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant