Skip to content

Latest commit

 

History

History
255 lines (182 loc) · 7.28 KB

step_by_step_contribute.md

File metadata and controls

255 lines (182 loc) · 7.28 KB
Raw

Step By Step Contribute Example

This document introduces a step by step example of contriuting to DM.

Please perform the following steps to create your Pull Request to this repository. If don't like to use command, you can also use GitHub Desktop, which is easier to get started.

Note:

This section takes creating a PR to the master branch as an example. Steps of creating PRs to other branches are similar.

Step 1: Fork the repository

  1. Visit the project: https://github.com/pingcap/dm
  2. Click the Fork button on the top right and wait it to finish.

Step 2: Clone the forked repository to local storage

cd $working_dir # Comes to the directory that you want put the fork in, for example, "cd ~/code"
git clone git@github.com:$user/dm.git # Replace "$user" with your GitHub ID

cd $working_dir/dm
git remote add upstream git@github.com:pingcap/dm.git # Adds the upstream repo
git remote -v # Confirms that your remote makes sense

Step 3: Setting up your development environment

  1. Setting up a Go development environment: How to Write Go Code.

    Note:

    DM uses Go Modules to manage dependencies. The version of Go should be 1.13 or above.

    You'll need GOPATH defined, and PATH modified to access your Go binaries. A common setup is the following but you could always google a setup for your own flavor.

    export GOPATH=$HOME/go
export PATH=$PATH:$GOPATH/bin

    Then you can use make command to build DM.

    make build

  2. Setting up test environment. See Test Preparations for more details.

Step 4: Pick up a issue

You can start by finding an existing issue with the help wanted label in the DM repository. These issues are well suited for new contributors.

Note:

This section takes issue UCP: retrieve the configuration of the running task from the DM cluster as an example. Steps of pick up other issues are similar.

Step 5: Create a new branch

  1. Get your local master up-to-date with upstream/master.

    cd $working_dir/dm
git fetch upstream
git checkout master
git rebase upstream/master

  2. Create a new branch based on the master branch.

    git checkout -b new-branch-name

Step 6: Edit your code

Edit some code on the new-branch-name branch and save your changes to fix the issure. Below is a example to add get-task-config command for DM.

  1. Update the proto code for grpc

    // GetTaskCfg implements a rpc method to get task config
rpc GetTaskCfg(GetTaskCfgRequest) returns(GetTaskCfgResponse) {
    ...
}

// GetTaskCfgRequest is a rpc request for GetTaskCfg
message GetTaskCfgRequest {
    ...
}

// GetTaskCfgRequest is a rpc response for GetTaskCfg
message GetTaskCfgResponse {
    ...
}

  2. Generate proto code

    make generate_proto

  3. Generate mock code

    make generate_mock

  4. Add new command for dmctl in root commnd

    master.NewGetTaskCfgCmd()

  5. Implement new command for dmctl

    // NewGetTaskCfgCmd creates a getTaskCfg command
func NewGetTaskCfgCmd() *cobra.Command {
    ...
    cmd := &cobra.Command{
        Run:   getTaskCfgFunc,
    }
    return cmd
}

// getTaskCfgFunc does get task's config
func getTaskCfgFunc(cmd *cobra.Command, _ []string) {
    ...
    cli := common.MasterClient()
    resp, err := cli.GetTaskCfg(ctx, &pb.GetTaskCfgRequest{
        Name: taskName,
    })
    common.PrettyPrintResponse(resp)
}

  6. Implement new command for dm-master

    // GetTaskCfg implements MasterServer.GetSubTaskCfg
func (s *Server) GetTaskCfg(ctx context.Context, req *pb.GetTaskCfgRequest) (*pb.GetTaskCfgResponse, error) {
    ...
    cfg := s.scheduler.GetTaskCfg(req.Name)
    return &pb.GetTaskCfgResponse{
        Result: true,
        Cfg:    cfg,
    }, nil
}

  7. Add some error instance for your new command in error_list

    ErrSchedulerTaskNotExist = New(codeSchedulerTaskNotExist, ClassScheduler, ScopeInternal, LevelMedium, "task with name %s not exist", "Please use `query-status` command to see tasks.")

  8. Generate new errors.toml

    make terror_check

  9. Build your code

    make build

Step 7: Add Unit Test

  1. Add unit test for dm-master server

    func (t *testMaster) TestGetTaskCfg(c *check.C) {
    ...
}

  2. Setup a MySQL server with binlog enabled first and set GTID_MODE=ON

    docker run --rm --name mysql-3306 -p 3306:3306 -e MYSQL_ALLOW_EMPTY_PASSWORD=true mysql:5.7.22 --log-bin=mysql-bin --port=3306 --bind-address=0.0.0.0 --binlog-format=ROW --server-id=1 --gtid_mode=ON --enforce-gtid-consistency=true > mysql.3306.log 2>&1 &

  3. Run unit test

    make unit_test

Step 8: Add Integration Test

  1. Add integration test for dmctl command

    function get_task_config_to_file() {
    ...
}

  2. Setup two MySQL server with binlog enabled first and set GITD_MODE=ON

    docker run --rm --name mysql-3306 -p 3306:3306 -e MYSQL_ROOT_PASSWORD=123456 mysql:5.7.22 --log-bin=mysql-bin --port=3306 --bind-address=0.0.0.0 --binlog-format=ROW --server-id=1 --gtid_mode=ON --enforce-gtid-consistency=true > mysql.3306.log 2>&1 &
docker run --rm --name mysql-3307 -p 3307:3307 -e MYSQL_ROOT_PASSWORD=123456 mysql:5.7.22 --log-bin=mysql-bin --port=3307 --bind-address=0.0.0.0 --binlog-format=ROW --server-id=1 --gtid_mode=ON --enforce-gtid-consistency=true > mysql.3307.log 2>&1 &

  3. Run integration test

    make integration_test

Step 9: Commit your changes

git status # Checks the local status
git add <file> ... # Adds the file(s) you want to commit. If you want to commit all changes, you can directly use `git add .`
git commit -m "commit-message: update the xx"

Step 10: Keep your branch in sync with upstream/master

# While on your new branch
git fetch upstream
git rebase upstream/master

Step 11: Push your changes to the remote

git push -u origin new-branch-name # "-u" is used to track the remote branch from origin

Step 12: Create a pull request

  1. Visit your fork at https://github.com/$user/dm (replace $user with your GitHub ID)
  2. Click the Compare & pull request button next to your new-branch-name branch to create your PR.

Now, your PR is successfully submitted! After this PR is merged, you will automatically become a contributor to DM.

Note:

You can find this contribute example in PR #798

Contact

Join the Slack channel: #sig-tools