Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.78 Clippy Warnings #1400

Closed
ctm opened this issue May 2, 2024 · 4 comments
Closed

Rust 1.78 Clippy Warnings #1400

ctm opened this issue May 2, 2024 · 4 comments
Assignees
@ctm
Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon

Comments

@ctm
Copy link
Owner

ctm commented May 2, 2024

Fix the clippy warnings that are appearing now that rust 1.78 is out.
@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon easy Trivial to do (even when tired!) and semi-worthwhile labels May 2, 2024
@ctm ctm self-assigned this May 2, 2024
@ctm
Copy link
Owner Author

ctm commented May 2, 2024

I don't think I can turn off the #[wasm_bindgen] complaints. Looks like this is fixed in nightly, but slipped into stable. It's been reported in wasm-bindgen.

@ctm
Copy link
Owner Author

ctm commented May 2, 2024

All the ones I can fix, I have fixed. I'm going to run a local smoke test and then run all the tests before deploying.

@ctm
Copy link
Owner Author

ctm commented May 2, 2024

Deploying.

@ctm ctm closed this as completed May 2, 2024
@ctm
Copy link
Owner Author

ctm commented Jun 11, 2024

FWIW, the wasm_bindgen warnings go away with Rust 1.79, which comes out in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctm ctm

Labels
chore Maintenance or other non-bug, non-feature easy Trivial to do (even when tired!) and semi-worthwhile high priority Should be done fairly soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctm