Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yew #280

Closed
ctm opened this issue Jun 30, 2020 · 4 comments
Closed

Update yew #280

ctm opened this issue Jun 30, 2020 · 4 comments
Assignees
@ctm
Labels
chore Maintenance or other non-bug, non-feature

Comments

@ctm
Copy link
Owner

ctm commented Jun 30, 2020

Yew 0.17 is out, so we should update to it immediately.
@ctm ctm added chore Maintenance or other non-bug, non-feature high priority Should be done fairly soon labels Jun 30, 2020
@ctm ctm self-assigned this Jun 30, 2020
@ctm
Copy link
Owner Author

ctm commented Jun 30, 2020

Updated. Required me to change how I focus elements, but also resulted in me fixing a regression that I wasn't even aware of. Tables weren't coming up focused on chat. They are now though.

Deploying now.

@ctm ctm closed this as completed Jun 30, 2020
@ctm
Copy link
Owner Author

ctm commented Jun 30, 2020

Oops. I ran into a surprising change in yew that may be a bug.

@ctm ctm reopened this Jun 30, 2020
@ctm ctm removed the high priority Should be done fairly soon label Jun 30, 2020
@ctm
Copy link
Owner Author

ctm commented Jul 1, 2020

I've temporarily switched to GitHub yew and yew-router and they seem to work. I'm sure there will be a point release soon, but I'm deploying what I have now. I don't think there will be problems, but if there are, I'd rather give the yew authors and maintainers more time.

@ctm ctm closed this as completed Jul 1, 2020
@ctm
Copy link
Owner Author

ctm commented Jul 1, 2020

FTR, the point release was out shortly after I made my temporary switch, so we're back to official Yew again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctm ctm

Labels
chore Maintenance or other non-bug, non-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctm