feat(cubesql): Fill pg_description table with cube and members descriptions #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8618 +/- ##
==========================================
+ Coverage 82.58% 82.59% +0.01%
==========================================
Files 210 210
Lines 77148 77175 +27
==========================================
+ Hits 63709 63741 +32
+ Misses 13439 13434 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
pg-description
branch
from
f03a57e
to
6e0b608
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
paveltiunov
approved these changes
Aug 26, 2024
mcheshkov
force-pushed
the
pg-description
branch
from
6e0b608
to
d64cdb2
Compare
mcheshkov
force-pushed
the
pg-description
branch
from
d64cdb2
to
99df4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Fill
pg_catalog.pg_descriptiontable as if descriptions to cubes/dimensions/measures/segmetns were added withCOMMENT ON. https://www.postgresql.org/docs/16/sql-comment.html