fix(schema-compiler): Warn when COUNT(*) is referenced in a view where count is not defined
#8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MazterQyou
force-pushed
the
schema-compiler/count-in-view
branch
from
4815da3
to
c03ed45
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
MazterQyou
force-pushed
the
schema-compiler/count-in-view
branch
from
c03ed45
to
56488a5
Compare
…here `count` is not defined
MazterQyou
force-pushed
the
schema-compiler/count-in-view
branch
from
56488a5
to
2c13d70
Compare
paveltiunov
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds a meaningful error for queries where
COUNT(*)was referenced, but is not part of a view, and as such is ambiguous.