Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplementedError: Slice step must be 1 #196

Closed
TomNicholas opened this issue Jun 1, 2023 · 1 comment · Fixed by #270
Closed

NotImplementedError: Slice step must be 1 #196

TomNicholas opened this issue Jun 1, 2023 · 1 comment · Fixed by #270
Labels
bug Something isn't working

Comments

@TomNicholas
Copy link
Member

Screenshot from 2023-06-01 14-24-14

@TomNicholas TomNicholas added the bug Something isn't working label Jun 1, 2023
@tomwhite
Copy link
Member

tomwhite commented Jun 2, 2023

We could implement this for step > 1 by making the output chunks be 1/step of the size of the input in the indexed dimension. This would ensure that the output chunk doesn't read from a potentially large number of input chunks if step was large (100 in this case), which could be slow and unreliable. We could follow with a rechunk to restore the original chunk size. I think the hardest bit would be doing the indexing arithmetic.

Are you blocked on this or did you find a workaround @TomNicholas?

Also, note there's a test covering this case (it currently just checks for NotImplementedError).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants