Add map_selection primitive to replace map_direct
#595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case where num_input_blocks=1 with an iterator Introduce iterable_input_blocks to distinguish between input blocks that are retrieved via an iterator and those that are not Remove requirement for num_input_blocks to be uniform
tomwhite
force-pushed
the
general-blockwise-selection
branch
from
faf9070 to
a513787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP, but the basic idea is to migrate calls to
map_directtomap_selection. The latter maps output block keys to an index selection on the input arrays, and is implemented using blockwise, so the optimizer will be able to fuse operations together. See #464.